RnD/reactor
3
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Grab code from previous Git Tea server without causing merge chaos #1

Closed
p.vanderwilt wants to merge 0 commits from old_main into main
pull from: old_main
merge into: RnD:main
Conversation 0 Commits - Files Changed -
p.vanderwilt commented 2025-09-22 14:31:53 +00:00
Member
Copy Link

Due to the initial commit, the histories do not allign. This pull request should solve that.

Due to the initial commit, the histories do not allign. This pull request should solve that.
p.vanderwilt added 110 commits 2025-09-22 14:31:54 +00:00
Initial commit 558a9fdbab
added initial file (unfinised) Add ASM3 class with 087acf8395 
kinetic parameters and rate computation method
Finished parameter objects 6ae7b5bf53
Implemented rates in rates function c2122e9537
Implemented first five stoichiometric equations c5a9a2e610
Finish stoichiometric matrix calculations and include missing kinetic parameter in compute_rates 6261ae9c47
Add project files including package.json, package-lock.json, .gitignore f9bd4279aa
Add optional state parameter to compute_rates, improve comments, and implement compute_dC method 333efcda52
Refactor ASM3 constructor to remove state parameter and update compute_dC method to use state directly; add Reactor_CSTR class for reactor simulation with forward Euler method 341af6db4d
Expand reactor class to build a simple CSTR model. Moved some functionality from asm3_class to reactor. 603a1d2283
Fix structure and improve comments in ASM3 and Reactor_CSTR classes b210a71657
Add advanced-reactor node-red implementation and update package.json references 49334f59e9
Fixed node not showing up in pallete. 2182bed343
Fixed bugs and hard coded config for now. 91482c564d
Merge pull request 'Absolute MVP with hardcoded config and output via terminal' (#1) from experimental into main bf203c5219 
Reviewed-on: p.vanderwilt/asm3#1
Add fluid volume and initial component inputs to advanced-reactor node edit dialogue 05d33b7f39
Refactor advanced-reactor node to improve input handling and initialize reactor properties d71698d94e
Add effluent output handling 5b7f7a3cef
Merge branch 'main' into experimental ded9c55dc4
Merge pull request 'Implemented node configuration and Effluent output' (#2) from experimental into main c5f6dcecae 
Reviewed-on: p.vanderwilt/asm3#2
Add number of inlets input handling to advanced-reactor node d0f8ada144
Add recirculation pump node with input handling and flow management 5281696a21
Bug fix for now. Need to figure out how clock pulse will work. 3ba98d2362
Rixed multiplying message bug. c8c588600c
Add optional kLa input and calculation to advanced-reactor node 1da7a9f602
Add settling basin node, fixed issue with object assignment 0469f678c5
Merge branch 'main' into experimental 167014a24b
Merge pull request 'Implemented recirculation pump and settling tank' (#3) from experimental into main c2caa7fb46 
Reviewed-on: p.vanderwilt/asm3#3
Close volume balance and minor fixes 288cf905d1
Prevent negative values in reactor state 5bd094f4a6
Fix major bug in calculation of dC_out in tick_fe method to account for outflow 85df04e215
Merge branch 'main' into experimental 8d270c37c3
Merge pull request 'Fix outflow' (#4) from experimental into main 3d3304f23a 
Reviewed-on: p.vanderwilt/asm3#4
Added speed-up factor 62b034fb76
Add support for multiple reactor types (CSTR and PFR) with corresponding properties (Dichelet BC for now) 70531a3a59
Implement Danckwerts boundary condition in tick_fe method for Reactor_PFR e6c1e21c16
Fixed various bugs e5c9010093
Add typed input fields for reactor length and resolution in advanced-reactor, fixed NaN bug in reactor length 6b57a46aab
Merge pull request 'MVP for dispersion model' (#5) from experimental into main c279552d7e 
Reviewed-on: p.vanderwilt/asm3#5
Add dispersion setting in advanced-reactor and initialize axial dispersion to zero in Reactor_PFR f2d94b26c5
Working on fixing the Derivative operators and BCs 2e76f733a8
Fix boundary conditions in gradient and second derivative operators for Reactor_PFR 9f13229785
Refactor dispersion and boundary condition handling in Reactor_PFR bb74fc86c2
Handle division by zero in rate calculations for ASM3 0cc6538003
Add checks for NaN values in Reactor_PFR calculations and update hydrolysis rate calculation to handle division by zero 8215c5ed9a
Enhance makeDoperator to support higher-order central gradient schemes and improve boundary handling b2d32ba9f2
Changed the upper boundary to lower order scheme for now 3cc876533c
Improved wieghted finite differencing f4824b822c
Use Generalized boundary condition by Nauman and Mallikarjun 1983 e9847607e8
Remove depreciated variable dcc8562dbf
Remove mistake boundary condition f517b7764d
Merge pull request 'New axial dispersion model with Generalised boundary conditions' (#6) from experimental into main 0d12192ccc 
Reviewed-on: p.vanderwilt/asm3#6
Remove debug messages d0db1b416c
Refactor reactor node registration 25cd728b68
Refactor Reactor class structure and include inheritance for CSTR and PFR 1cda956d83
Refactor nodeClass for to mostly allign with the standard EVOLV structure fee6881f1b
Remove unnecessary node parameter _setupClass c23818c108
Refactor nodeClass to streamline configuration loading and reactor setup 530dac5c77
Add documentation 348307d999
Refactor reactor constructors to accept a config object for improved clarity and maintainability c239b71ad8
Refactor documentation in nodeClass and reactor_class for clarity and consistency 09e7072d16
Enhance reactor class with NaN checks and refactor methods for clarity 3f5b0eea32
Refactor advanced-reactor and nodeClass for improved readability and consistency c6b0cab067
Fixed bug in NaN assertion 4b49d10763
Refactor reactor class to improve NaN handling and removed magic numbers 6755f2bd28
Refactor reactor class to improve NaN handling and add utility function for NaN assertions a2cfb20e2c
Add debug assertions for state changes in Reactor classes fe3add4007
Enhance documentation for ASM3 class and its parameters b4ddb6b8df
Change file structure to align with project deb5269d1a
Refactor Reactor class to remove debug logs and enhance setter for influent data with conditional logging 302780726a
Merge pull request 'Refactor code to align with other projects in EVOLV' (#7) from refactor into main c89d5b0024 
Reviewed-on: p.vanderwilt/asm3#7
Add boundary condition input and update reactor configuration handling 01380c309f
Fix spelling of "Dirichlet" in advanced-reactor.html and specificClass.js 01318a2d3b
Refactor boundary condition handling to use adjustable parameter alpha in advanced-reactor and specificClass 5c03dddb79
Add temperature theta parameters and adjust reaction rate calculations in ASM3 class c1e331b5f0
Merge pull request 'Added temperature-dependent rate calculation to ASM3 model' (#12) from experimental into main 6bdfa07d92 
Reviewed-on: p.vanderwilt/asm3#12
Refactor boundary condition application in Reactor_PFR class for improved clarity and efficiency c566766c4d
Reset speedUpFactor in Reactor class for simulation acceleration, disable debug 0efa76fa6a
Add temperature handling 0f912b05e4
Switched around Debug point and added checks for Pe and Co_D 6fd86f71c8
Add generalFunctions dependency and implement basic measurement child registration in nodeClass 24de5a4c9f
Update temperature handling in Reactor class and remove redundant setter 6227bbe256
Merge pull request 'Switch temperature to Measurement node and finally fix boundary conditions properly' (#14) from experimental into main 6adf29427a 
Reviewed-on: p.vanderwilt/asm3#14
Added seperate process, DB and parent outputs d5db1ae0a0
Added handles for influent change emitter 633a088483
Deal with clock singal 73c2b654e1
Rewrite reactor to source and register it properly to node object b1719376cf
Minor optimisations 57aafe3e0b
Process output using tick function rather than clock message f81161b2d5
Merge pull request 'Implemented parent-child relations for reactor node' (#15) from multi-output into main a2dbd468d5 
Reviewed-on: p.vanderwilt/asm3#15
Add WIP oxygen measurement child relation ef02c47cff
Added loggin to advanced-reactor. Currently broken for some reason? da90224d3f
Renamed advanced-reactor to advancedReactor to prevent errors due to hyphen in name 31d30c6db3
Add position field and proper logging configuration 5ec9319b3f
Fixed position and log settings 2c9db0fcea
Temporary fix for undefined newTime value in updateState function fbbe5833b2
Add flows document 7a6825a80e
Fix COD balance 04a5b1a54f
Add Koch parameters a8928e50cc
Minor fix Koch parameters 1857031027
Update package-lock a4a5266040
Switch general functions to new implementation 0b49642668
Update generalFunctions dependency and enhance reactor child registration logic c2cd29db56
Enhance measurement child registration and update measurement handling in Reactor class f6b026928e
Fix subclass function 94ea4fe76b
Formatting 972d33355e
Fix measurement reference in child registration logic 223c4555b8
Fix measurement event listener registration in Reactor class 7a70f60655
Add time step configuration and input handling in advanced reactor 8f64fbe4e5
Rename repo 9147a3f7d0
p.vanderwilt closed this pull request 2025-09-22 14:41:18 +00:00
p.vanderwilt deleted branch old_main 2025-09-22 14:43:27 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
p.vanderwilt pimmoerman renederen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RnD/reactor#1
No description provided.
Delete Branch "old_main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?