RnD/reactor
3
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Recirculation Integration #4

Merged
p.vanderwilt merged 8 commits from recirculation-integration into main 2025-11-06 13:55:42 +00:00
Conversation 0 Commits 8 Files Changed 3 +48 -44
p.vanderwilt commented 2025-11-06 13:55:33 +00:00
Member
Copy Link

Add recirculation using rotating machine nodes

Add recirculation using rotating machine nodes
p.vanderwilt added 8 commits 2025-11-06 13:55:34 +00:00
Non-functioning prototype with partial rotating machine integration 3a820df7f2
Fix recirculation flow measurement to use getCurrentValue and handle undefined values 018215934e
Refactor recirculation flow calculation to ensure non-negative flow rates and correct measurement position 7b38c2f51a
Fix recirculation flow calculation to prevent negative flow rates and improve variable naming 6de4f9ec3e
Minor bug fix and change in report level when encountering invalid children eb787ec47f
minor variable name changes 4680b98418
Refactor child registration and connection methods to handle invalid inputs and improve readability e6923f2916
Refactor reactor node configuration to remove n_inlets and simplify inlet handling 3828e43c12
p.vanderwilt merged commit 4578667a96 into main 2025-11-06 13:55:42 +00:00
p.vanderwilt deleted branch recirculation-integration 2025-11-06 14:25:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
p.vanderwilt pimmoerman renederen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RnD/reactor#4
No description provided.
Delete Branch "recirculation-integration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?