RnD/reactor
3
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Implementation of new boundary conidtions #2

Closed
p.vanderwilt wants to merge 0 commits from boundary-conditions into main
pull from: boundary-conditions
merge into: RnD:main
Conversation 0 Commits - Files Changed -
p.vanderwilt commented 2025-10-16 13:33:14 +00:00
Member
Copy Link

New boundary conditions allowing for back diffusion between PFD reactors.

New boundary conditions allowing for back diffusion between PFD reactors.
p.vanderwilt added 10 commits 2025-10-16 13:33:15 +00:00
Use improved boundary conditions for upstream and downstream reactors 6c79d0ef9b
Fix reference error and improve child variable naming 5f4ebdc2af
Deal with mulitple parents and set downstreamReactor for improved boundary conditions 993482f8c0
Implement simple BCs d9511dc3c7
Rewrite for improved boundary condition 3aea0e55c4
Fix boundary conditions for advection cd3a19e66f
Functioning code, requires improved sequencing baecf2f599
Refactor measurement position assignment and update grid position calculation in Reactor classes to align with new generalFunctions 2a520be33b
Add dispersion constraint 1dc9cd0031
Add warnings for reactor child positioning and grid sizing discrepancies f44bac9aab
p.vanderwilt closed this pull request 2025-11-21 13:47:35 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
p.vanderwilt pimmoerman renederen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RnD/reactor#2
No description provided.
Delete Branch "boundary-conditions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?