Commit Graph

80 Commits

Author SHA1 Message Date
24de5a4c9f Add generalFunctions dependency and implement basic measurement child registration in nodeClass 2025-07-11 12:22:36 +02:00
6fd86f71c8 Switched around Debug point and added checks for Pe and Co_D 2025-07-09 15:37:29 +02:00
0f912b05e4 Add temperature handling 2025-07-09 10:29:54 +02:00
0efa76fa6a Reset speedUpFactor in Reactor class for simulation acceleration, disable debug 2025-07-08 15:41:41 +02:00
c566766c4d Refactor boundary condition application in Reactor_PFR class for improved clarity and efficiency 2025-07-08 15:29:55 +02:00
c1e331b5f0 Add temperature theta parameters and adjust reaction rate calculations in ASM3 class 2025-07-08 11:02:39 +02:00
5c03dddb79 Refactor boundary condition handling to use adjustable parameter alpha in advanced-reactor and specificClass 2025-07-08 10:03:03 +02:00
01318a2d3b Fix spelling of "Dirichlet" in advanced-reactor.html and specificClass.js 2025-07-07 14:58:52 +02:00
01380c309f Add boundary condition input and update reactor configuration handling 2025-07-07 14:47:50 +02:00
c89d5b0024 Merge pull request 'Refactor code to align with other projects in EVOLV' (#7) from refactor into main
Reviewed-on: p.vanderwilt/asm3#7
2025-07-07 10:26:46 +00:00
302780726a Refactor Reactor class to remove debug logs and enhance setter for influent data with conditional logging 2025-07-07 12:24:15 +02:00
deb5269d1a Change file structure to align with project 2025-07-07 11:59:11 +02:00
b4ddb6b8df Enhance documentation for ASM3 class and its parameters 2025-07-07 11:08:11 +02:00
fe3add4007 Add debug assertions for state changes in Reactor classes 2025-07-04 17:42:31 +02:00
a2cfb20e2c Refactor reactor class to improve NaN handling and add utility function for NaN assertions 2025-07-04 16:28:35 +02:00
6755f2bd28 Refactor reactor class to improve NaN handling and removed magic numbers 2025-07-04 16:03:42 +02:00
4b49d10763 Fixed bug in NaN assertion 2025-07-04 15:48:05 +02:00
c6b0cab067 Refactor advanced-reactor and nodeClass for improved readability and consistency 2025-07-04 15:14:03 +02:00
3f5b0eea32 Enhance reactor class with NaN checks and refactor methods for clarity 2025-07-04 14:58:38 +02:00
09e7072d16 Refactor documentation in nodeClass and reactor_class for clarity and consistency 2025-07-04 13:52:28 +02:00
c239b71ad8 Refactor reactor constructors to accept a config object for improved clarity and maintainability 2025-07-04 13:16:49 +02:00
348307d999 Add documentation 2025-07-04 13:09:20 +02:00
530dac5c77 Refactor nodeClass to streamline configuration loading and reactor setup 2025-07-04 12:51:37 +02:00
c23818c108 Remove unnecessary node parameter _setupClass 2025-07-04 12:16:08 +02:00
fee6881f1b Refactor nodeClass for to mostly allign with the standard EVOLV structure 2025-07-04 12:06:58 +02:00
1cda956d83 Refactor Reactor class structure and include inheritance for CSTR and PFR 2025-07-04 11:42:34 +02:00
25cd728b68 Refactor reactor node registration 2025-07-04 10:44:54 +02:00
d0db1b416c Remove debug messages 2025-07-04 10:01:46 +02:00
0d12192ccc Merge pull request 'New axial dispersion model with Generalised boundary conditions' (#6) from experimental into main
Reviewed-on: p.vanderwilt/asm3#6
2025-07-03 20:30:34 +00:00
f517b7764d Remove mistake boundary condition 2025-07-03 22:28:34 +02:00
dcc8562dbf Remove depreciated variable 2025-07-02 10:37:02 +02:00
e9847607e8 Use Generalized boundary condition by Nauman and Mallikarjun 1983 2025-07-01 16:08:35 +02:00
f4824b822c Improved wieghted finite differencing 2025-07-01 13:04:32 +02:00
3cc876533c Changed the upper boundary to lower order scheme for now 2025-06-30 15:46:13 +02:00
b2d32ba9f2 Enhance makeDoperator to support higher-order central gradient schemes and improve boundary handling 2025-06-30 12:50:02 +02:00
8215c5ed9a Add checks for NaN values in Reactor_PFR calculations and update hydrolysis rate calculation to handle division by zero 2025-06-28 19:19:38 +02:00
0cc6538003 Handle division by zero in rate calculations for ASM3 2025-06-27 17:29:20 +02:00
bb74fc86c2 Refactor dispersion and boundary condition handling in Reactor_PFR 2025-06-27 16:56:37 +02:00
9f13229785 Fix boundary conditions in gradient and second derivative operators for Reactor_PFR 2025-06-24 16:38:07 +02:00
2e76f733a8 Working on fixing the Derivative operators and BCs 2025-06-24 16:23:33 +02:00
f2d94b26c5 Add dispersion setting in advanced-reactor and initialize axial dispersion to zero in Reactor_PFR 2025-06-24 13:28:45 +02:00
c279552d7e Merge pull request 'MVP for dispersion model' (#5) from experimental into main
Reviewed-on: p.vanderwilt/asm3#5
2025-06-24 10:36:09 +00:00
6b57a46aab Add typed input fields for reactor length and resolution in advanced-reactor, fixed NaN bug in reactor length 2025-06-24 12:32:11 +02:00
e5c9010093 Fixed various bugs 2025-06-24 11:20:28 +02:00
e6c1e21c16 Implement Danckwerts boundary condition in tick_fe method for Reactor_PFR 2025-06-23 17:46:55 +02:00
70531a3a59 Add support for multiple reactor types (CSTR and PFR) with corresponding properties (Dichelet BC for now) 2025-06-23 16:58:02 +02:00
62b034fb76 Added speed-up factor 2025-06-19 20:55:42 +02:00
3d3304f23a Merge pull request 'Fix outflow' (#4) from experimental into main
Reviewed-on: p.vanderwilt/asm3#4
2025-06-18 22:24:22 +00:00
8d270c37c3 Merge branch 'main' into experimental 2025-06-18 22:24:02 +00:00
85df04e215 Fix major bug in calculation of dC_out in tick_fe method to account for outflow 2025-06-19 00:16:54 +02:00