Commit Graph

155 Commits

Author SHA1 Message Date
033a56a9e0 Enhance comments and documentation in Reactor classes for clarity and maintainability 2025-11-21 12:29:46 +01:00
dd70b8c890 Fix CSTR PFR distinctions 2025-11-21 11:02:40 +01:00
3d93f2a7b9 Fix minor bug 2025-11-14 14:48:39 +01:00
cc89833530 Update state handling in reactor class and optimize time iteration logic 2025-11-14 13:11:09 +01:00
f3bbf63602 Add return pump update in reactor state change 2025-11-14 12:55:34 +01:00
70af0885e3 Prepare for working with relative time 2025-11-14 12:34:52 +01:00
dbfc4a81b2 Remove unused / depreciated input handling 2025-11-14 12:33:16 +01:00
f14e2c8d8e Reformat asm constants 2025-11-13 16:52:38 +01:00
7e34b9aa71 Add real-time calculation for dx based on length and resolution inputs 2025-11-13 13:59:56 +01:00
2b37163a8a Minor fixes 2025-11-07 16:51:48 +01:00
a106276ca6 Add additional ASM constants, add other sensor handling, fix bug in kla model 2025-11-07 11:59:24 +01:00
ffb4080f14 Refactor boundary condition handling in Reactor_PFR class for improved clarity and efficiency 2025-11-06 17:24:10 +01:00
260d04b96f Minor optimisations in code and clarification 2025-11-06 16:36:51 +01:00
9f060d2dd0 Refactor, minor changes and remove depreciated functions 2025-11-06 16:09:18 +01:00
b0dd9b6a8f Refactor ASM3 module to export ASM_CONSTANTS and update references in Reactor classes 2025-11-06 15:47:18 +01:00
5c41dc44a3 Clean up unused code 2025-11-06 15:46:43 +01:00
4578667a96 Merge pull request 'Recirculation Integration' (#4) from recirculation-integration into main
Reviewed-on: #4
2025-11-06 13:55:42 +00:00
3828e43c12 Refactor reactor node configuration to remove n_inlets and simplify inlet handling 2025-11-06 14:51:06 +01:00
e6923f2916 Refactor child registration and connection methods to handle invalid inputs and improve readability 2025-10-31 11:54:28 +01:00
4680b98418 minor variable name changes 2025-10-23 17:16:10 +02:00
eb787ec47f Minor bug fix and change in report level when encountering invalid children 2025-10-22 14:40:56 +02:00
HorriblePerson555
6de4f9ec3e Fix recirculation flow calculation to prevent negative flow rates and improve variable naming 2025-10-21 13:02:41 +02:00
HorriblePerson555
7b38c2f51a Refactor recirculation flow calculation to ensure non-negative flow rates and correct measurement position 2025-10-21 12:32:21 +02:00
HorriblePerson555
018215934e Fix recirculation flow measurement to use getCurrentValue and handle undefined values 2025-10-20 17:37:29 +02:00
HorriblePerson555
3a820df7f2 Non-functioning prototype with partial rotating machine integration 2025-10-20 16:45:53 +02:00
HorriblePerson555
670c4deacb Merge branch 'boundary-conditions' 2025-10-16 15:36:37 +02:00
HorriblePerson555
f44bac9aab Add warnings for reactor child positioning and grid sizing discrepancies 2025-10-16 15:30:51 +02:00
1dc9cd0031 Add dispersion constraint 2025-10-14 12:48:43 +02:00
2a520be33b Refactor measurement position assignment and update grid position calculation in Reactor classes to align with new generalFunctions 2025-10-10 11:27:55 +02:00
baecf2f599 Functioning code, requires improved sequencing 2025-10-02 17:39:31 +02:00
cd3a19e66f Fix boundary conditions for advection 2025-10-02 13:48:47 +02:00
3aea0e55c4 Rewrite for improved boundary condition 2025-10-01 16:50:48 +02:00
442ddc60ed Fix syntax error 2025-10-01 11:50:35 +02:00
d9511dc3c7 Implement simple BCs 2025-09-30 15:36:25 +02:00
993482f8c0 Deal with mulitple parents and set downstreamReactor for improved boundary conditions 2025-09-29 16:58:46 +02:00
5f4ebdc2af Fix reference error and improve child variable naming 2025-09-29 15:45:07 +02:00
6c79d0ef9b Use improved boundary conditions for upstream and downstream reactors 2025-09-29 15:34:54 +02:00
04306d0996 Fix measurement type string for oxygen in _updateMeasurement method 2025-09-29 09:40:17 +02:00
2bc244cae7 Refactor measurement update handling in Reactor_PFR class to include default case for measurement types 2025-09-26 16:36:09 +02:00
254f9eec5a Fix measurement event listener to use correct measurement reference 2025-09-26 16:33:00 +02:00
109fd182df Refactor measurement position handling in Reactor class 2025-09-26 14:51:18 +02:00
bf5f265a76 Update measurement handling in Reactor class and rename oxygen measurement type 2025-09-26 10:17:00 +02:00
905674ce58 Update dependencies and correct node name 2025-09-24 15:27:08 +02:00
da1cff55ba Resolve merge conflicts from migration 2025-09-22 16:40:22 +02:00
9147a3f7d0 Rename repo 2025-09-22 16:19:00 +02:00
ea35038aa1 Initial commit 2025-09-22 14:11:36 +00:00
8f64fbe4e5 Add time step configuration and input handling in advanced reactor 2025-09-22 15:17:25 +02:00
7a70f60655 Fix measurement event listener registration in Reactor class 2025-09-19 13:26:45 +02:00
223c4555b8 Fix measurement reference in child registration logic 2025-09-16 15:54:31 +02:00
972d33355e Formatting 2025-09-16 11:44:29 +02:00