From 5ec9319b3f20e03d8a6822a44b1ab91069c227ff Mon Sep 17 00:00:00 2001
From: "p.vanderwilt" <p.van.der.wilt@brabantsedelta.nl>
Date: Thu, 24 Jul 2025 12:13:16 +0200
Subject: [PATCH] Add position field and proper logging configuration

---
 advancedReactor.html | 9 +++++++++
 advancedReactor.js   | 2 +-
 src/nodeClass.js     | 7 ++++++-
 src/specificClass.js | 2 +-
 4 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/advancedReactor.html b/advancedReactor.html
index 3bdbe31..7d1f09f 100644
--- a/advancedReactor.html
+++ b/advancedReactor.html
@@ -107,6 +107,11 @@
                 window.EVOLV.nodes['advancedReactor'].loggerMenu.saveEditor(this);
             }
 
+            // save position field
+            if (window.EVOLV?.nodes?.measurement?.positionMenu?.saveEditor) {
+                window.EVOLV.nodes.rotatingMachine.positionMenu.saveEditor(this);
+            }
+
             let volume = parseFloat($("#node-input-volume").typedInput("value"));
             if (isNaN(volume) || volume <= 0) {
                 RED.notify("Fluid volume not set correctly", {type: "error"});
@@ -215,6 +220,10 @@
     <!-- Logger fields injected here -->
 	<div id="logger-fields-placeholder"></div>
 
+    <!-- Position fields will be injected here -->
+    <div id="position-fields-placeholder"></div>
+
+
 </script>
 
 <script type="text/html" data-help-name="advancedReactor">
diff --git a/advancedReactor.js b/advancedReactor.js
index b904029..311698e 100644
--- a/advancedReactor.js
+++ b/advancedReactor.js
@@ -17,7 +17,7 @@ module.exports = function (RED) {
     // Serve /advancedReactor/menu.js
     RED.httpAdmin.get(`/${nameOfNode}/menu.js`, (req, res) => {
         try {
-            const script = menuMgr.createEndpoint(nameOfNode, ['logger']);
+            const script = menuMgr.createEndpoint(nameOfNode, ['logger', 'position']);
             res.type('application/javascript').send(script);
         } catch (err) {
             res.status(500).send(`// Error generating menu: ${err.message}`);
diff --git a/src/nodeClass.js b/src/nodeClass.js
index 637ec5b..018610e 100644
--- a/src/nodeClass.js
+++ b/src/nodeClass.js
@@ -73,9 +73,14 @@ class nodeClass {
             general: {
                 name: uiConfig.name || this.name,
                 id: this.node.id,
-                unit: null
+                unit: null,
+                logging: {
+                    enabled: uiConfig.enableLog,
+                    logLevel: uiConfig.logLevel
+                }
             },
             functionality: {
+                positionVsParent: uiConfig.positionVsParent || 'atEquipment', // Default to 'atEquipment' if not specified
                 softwareType: "reactor" // should be set in config manager
             },
             reactor_type: uiConfig.reactor_type,
diff --git a/src/specificClass.js b/src/specificClass.js
index 81ba36b..679e6d0 100644
--- a/src/specificClass.js
+++ b/src/specificClass.js
@@ -22,7 +22,7 @@ class Reactor {
   constructor(config) {
     this.config = config;
     // EVOLV stuff
-    this.logger = new logger(undefined, undefined, config.general.name);
+    this.logger = new logger(this.config.general.logging.enabled, this.config.general.logging.logLevel, config.general.name);
     this.emitter = new EventEmitter();
     this.measurements = new MeasurementContainer();
     this.upstreamReactor = null;