RnD/generalFunctions
3
0
Fork 2
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

Compare commits

base: RnD:dev-Rene
Branches Tags
RnD:main RnD:dev-Rene RnD:dev-Pieter
...
compare: RnD:5117df14db0b72b74e70e33e6b7ad126de18df9f
Branches Tags
RnD:dev-Rene RnD:main RnD:dev-Pieter

2 Commits
dev-Rene ... 5117df14db

Author SHA1 Message Date
p.vanderwilt
5117df14db Fix number comparisons for position values 2025-10-03 15:55:20 +02:00
p.vanderwilt
c70bed2b39 Duplicated emitter to account for both string and num based events 2025-10-03 15:18:42 +02:00
2 changed files with 49 additions and 48 deletions
Expand all files Collapse all files

2
src/measurements/MeasurementBuilder.js
View File

@@ -40,7 +40,7 @@ class MeasurementBuilder {
if (!this.variant) { if (!this.variant) {
throw new Error('Measurement variant is required'); throw new Error('Measurement variant is required');
} }
if (!this.position) { if (Number.isNaN(this.position)) {
throw new Error('Measurement position is required'); throw new Error('Measurement position is required');
} }

3
src/measurements/MeasurementContainer.js
View File

@@ -154,6 +154,7 @@ class MeasurementContainer {
}; };
// Emit the exact event your parent expects // Emit the exact event your parent expects
this.emitter.emit(`${this._currentType}.${this._currentVariant}.${this._convertPositionNum2Str(this._currentPosition)}`, eventData);
this.emitter.emit(`${this._currentType}.${this._currentVariant}.${this._currentPosition}`, eventData); this.emitter.emit(`${this._currentType}.${this._currentVariant}.${this._currentPosition}`, eventData);
// console.log(`Emitted event: ${this._currentType}.${this._currentVariant}.${this._currentPosition}`, eventData); // console.log(`Emitted event: ${this._currentType}.${this._currentVariant}.${this._currentPosition}`, eventData);
@@ -283,7 +284,7 @@ class MeasurementContainer {
// Helper methods // Helper methods
_ensureChainIsValid() { _ensureChainIsValid() {
if (!this._currentType || !this._currentVariant || !this._currentPosition) { if (!this._currentType || !this._currentVariant || Number.isNaN(this._currentPosition)) {
if (this.logger) { if (this.logger) {
this.logger.error('Incomplete measurement chain, required: type, variant, and position'); this.logger.error('Incomplete measurement chain, required: type, variant, and position');
} }