From d7017b5d33af6a2e0bb85adc9356a105e09c139d Mon Sep 17 00:00:00 2001 From: "p.vanderwilt" Date: Fri, 26 Sep 2025 13:51:59 +0200 Subject: [PATCH 1/3] Add logger checks before error logging for position validation --- src/measurements/MeasurementContainer.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/measurements/MeasurementContainer.js b/src/measurements/MeasurementContainer.js index 516e182..b7dc405 100644 --- a/src/measurements/MeasurementContainer.js +++ b/src/measurements/MeasurementContainer.js @@ -427,7 +427,9 @@ class MeasurementContainer { return Number.NEGATIVE_INFINITY; default: - this.logger.error(`Invalid positionVsParent provided: ${positionString}`); + if (this.logger) { + this.logger.error(`Invalid positionVsParent provided: ${positionString}`); + } return; } } @@ -442,7 +444,10 @@ class MeasurementContainer { if (positionValue > 0) { return "downstream"; } - this.logger.error(`Invalid position provided: ${positionValue}`); + + if (this.logger) { + this.logger.error(`Invalid position provided: ${positionValue}`); + } } } From bde2dcf7d89612fde44bb79dc8aa2309cac20dd4 Mon Sep 17 00:00:00 2001 From: "p.vanderwilt" Date: Fri, 26 Sep 2025 14:26:41 +0200 Subject: [PATCH 2/3] Add oygen sensor to assets --- datasets/assetData/assetData.json | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/datasets/assetData/assetData.json b/datasets/assetData/assetData.json index 6df8a84..316708a 100644 --- a/datasets/assetData/assetData.json +++ b/datasets/assetData/assetData.json @@ -59,15 +59,11 @@ ] }, { - "name": "Level", + "name": "Quantity (oxygen)", "models": [ { - "name": "VegaLevel 10", - "units": ["m", "ft", "mm"] - }, - { - "name": "VegaLevel 20", - "units": ["m", "ft", "mm"] + "name": "VegaOxySense 10", + "units": ["g/m³", "mol/m³"] } ] } From 0fb42865ff978401671a14a909316b376e4764aa Mon Sep 17 00:00:00 2001 From: "p.vanderwilt" Date: Fri, 26 Sep 2025 15:51:40 +0200 Subject: [PATCH 3/3] Add distance configuration to measurement settings --- src/configs/measurement.json | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/configs/measurement.json b/src/configs/measurement.json index c061ae9..5c45d96 100644 --- a/src/configs/measurement.json +++ b/src/configs/measurement.json @@ -91,6 +91,13 @@ ], "description": "Defines the position of the measurement relative to its parent equipment or system." } + }, + "distance":{ + "default": null, + "rules": { + "type": "number", + "description": "Defines the position of the measurement relative to its parent equipment or system." + } } }, "asset": {